follow-up fix for #377

evanw · Sep 11, 2020 · 3a9ad1e · 3a9ad1e
1 parent 334f4a8
commit 3a9ad1e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/internal/parser/parser.go b/internal/parser/parser.go
@@ -4434,7 +4434,12 @@ func (p *parser) parseStmt(opts parseStmtOpts) ast.Stmt {
 				switch p.lexer.Identifier {
 				case "type":
 					// "export type foo = ..."
+					typeRange := p.lexer.Range()
 					p.lexer.Next()
+					if p.lexer.HasNewlineBefore {
+						p.log.AddError(&p.source, logger.Loc{Start: typeRange.End()}, "Unexpected newline after \"type\"")
+						panic(lexer.LexerPanic{})
+					}
 					p.skipTypeScriptTypeStmt(parseStmtOpts{isModuleScope: opts.isModuleScope, isExport: true})
 					return ast.Stmt{Loc: loc, Data: &ast.STypeScript{}}
 

diff --git a/internal/parser/parser_ts_test.go b/internal/parser/parser_ts_test.go
@@ -118,6 +118,7 @@ func TestTSTypes(t *testing.T) {
 	expectPrintedTS(t, "type x = {0: number, readonly 1: boolean}\n[]", "[];\n")
 	expectPrintedTS(t, "type x = {'a': number, readonly 'b': boolean}\n[]", "[];\n")
 	expectPrintedTS(t, "type\nFoo = {}", "type;\nFoo = {};\n")
+	expectParseErrorTS(t, "export type\nFoo = {}", "<stdin>: error: Unexpected newline after \"type\"\n")
 	expectPrintedTS(t, "let x: {x: 'a', y: false, z: null}", "let x;\n")
 	expectPrintedTS(t, "let x: {foo(): void}", "let x;\n")
 	expectPrintedTS(t, "let x: {['x']: number}", "let x;\n")