[email protected] throws maximum call stack size exceeded

[merceyz]

Describe the bug

Starting in [email protected], bundling Yarn throws the following error:

wasm://wasm/026e9252:1


RangeError: Maximum call stack size exceeded
    at wasm://wasm/026e9252:wasm-function[2854]:0x4068ce
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d
    at wasm://wasm/026e9252:wasm-function[2854]:0x40de9d

Node.js v18.14.0

To Reproduce

Try to bundle Yarn at yarnpkg/berry@76ad929

git clone --filter=tree:0 https://github.com/yarnpkg/berry
cd berry
git checkout 76ad929ed5c51fda31c5631426703ca7d16ac76f
yarn build:cli

[evanw]

I suspect upgrading from Go 1.19.5 to Go 1.20.0 caused this. Go 1.20 likely uses more stack space and/or represents the stack differently than Go 1.19. I may have to revert the upgrade.

[evanw]

I have investigated this. The problem is coming from this file, which has a very deeply-nested AST (>400 levels deep): https://unpkg.com/[email protected]/index.js. So it's understandable that this is a stack overflow. Hmm.

[evanw]

I'm going to try switching the affected code from recursion to iteration. Please let me know if this doesn't resolve the issue.