Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parcel 2 in esbuild benchmarks #669

Closed
devongovett opened this issue Jan 13, 2021 · 2 comments
Closed

Update Parcel 2 in esbuild benchmarks #669

devongovett opened this issue Jan 13, 2021 · 2 comments

Comments

@devongovett
Copy link

The latest Parcel 2 nightlies are much faster than shown on the esbuild website and in the readme. The three.js benchmark builds in 53s on my machine (~2x faster). It would be great if you could update the data shown in your charts as well. 😄

image

@evanw
Copy link
Owner

evanw commented Jan 13, 2021

That's really exciting! I've been following along with your work so I know how much work went into this. Congrats on the improvements. I'll update my benchmarks soon.

@evanw
Copy link
Owner

evanw commented Jan 13, 2021

I just finished re-running the benchmarks. Here's what I got:

Time:

JS benchmark TS benchmark
2.0.0-nightly.475 108.66s 53.13s
2.0.0-nightly.527 56.71s (1.92x faster) 42.32s (1.26x faster)

Size:

JS benchmark TS benchmark
2.0.0-nightly.475 5.81mb 1.68mb
2.0.0-nightly.527 5.92mb (2% larger) 1.68mb (no change)

So great news that the 2x speedup works out in practice! This puts Parcel 2 in between Webpack 4 and Webpack 5 in terms of performance.

However, it looks like the latest update broke source maps. I'm not completely sure what happened but in my usual test of inserting throw new Error into the BoxGeometry constructor and then running the hello world example, it's mapping the location to the wrong file.

I consider working source maps to be a requirement for inclusion in the benchmark. Can you confirm whether or not you can also reproduce the source map issue? And would it be possible to fix source maps in Parcel 2 so that I can update the benchmark with the new times?

Edit: This is potentially the same problem as parcel-bundler/parcel#5630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants