Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name for terminal colors used in Windows logger #1074

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Fix variable name for terminal colors used in Windows logger #1074

merged 1 commit into from
Mar 28, 2021

Conversation

Gelio
Copy link
Contributor

@Gelio Gelio commented Mar 28, 2021 •
edited
Loading

The tests for 471e743 started failing as the terminalColors variable name used in the Windows logger was not updated

@Gelio Gelio mentioned this pull request Mar 28, 2021
Closed
@evanw
Copy link
Owner

evanw commented Mar 28, 2021

Thanks. Sorry about that.

@evanw evanw merged commit f0c9d76 into evanw:master Mar 28, 2021
@Gelio Gelio deleted the fix-tests-for-windows branch March 28, 2021 11:31
@Gelio
Copy link
Contributor Author

Gelio commented Mar 28, 2021

No worries, I'm glad I could help 🙂

@thlorenz thlorenz mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gelio @evanw