make: always set CGO_ENABLED=0 for platform builds #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGO_ENABLED defaults to "1" if a Go build targets the host system, so that it can use the system's libc and any other libraries. For cross-builds (when either the target GOOS or GOARCH don't match the host's), the Go tool can't assume that a C cross-compiler and the necessary headers are present, so the default is CGO_ENABLED=0. This can result in binaries published to NPM being inconsistently static, since the one matching the host's will be the only one to dynamically link C libraries. For example, on linux/amd64: $ make platform-linux platform-windows platform-linux-arm64 platform-darwin platform-freebsd [...] $ ldd npm/esbuild-*/bin/* npm/esbuild-darwin-64/bin/esbuild: not a dynamic executable npm/esbuild-freebsd-64/bin/esbuild: not a dynamic executable npm/esbuild-linux-64/bin/esbuild: linux-vdso.so.1 (0x00007ffd24570000) libpthread.so.0 => /usr/lib/libpthread.so.0 (0x00007f35a6718000) libc.so.6 => /usr/lib/libc.so.6 (0x00007f35a654b000) /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007f35a6765000) npm/esbuild-linux-arm64/bin/esbuild: not a dynamic executable npm/esbuild-wasm/bin/esbuild: not a dynamic executable npm/esbuild-windows-32/bin/esbuild: not a dynamic executable npm/esbuild-windows-64/bin/esbuild: not a dynamic executable With this change, we always force CGO_ENABLED=0, and the resulting binaries are consistently non-dynamic no matter the host platform. This change should be safe, as esbuild seems to have zero cgo code, and the majority of platform builds for NPM were already defaulting to CGO_ENABLED=0.
|
Thanks for the detailed description. I wasn't aware of this issue. Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)