Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix panic when optional chain partially replaced with defines #3554

Merged
merged 5 commits into from
Dec 18, 2023
Merged

fix: fix panic when optional chain partially replaced with defines #3554

merged 5 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. fix: fix panic when optional chain partially replaced with defines

    @hi-ogawa
    hi-ogawa committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8c4631b View commit details
    Browse the repository at this point in the history

  2. refactor: check childContainsOptionalChain to bail out before panic

    @hi-ogawa
    hi-ogawa committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8eba3c9 View commit details
    Browse the repository at this point in the history

  3. chore: revert old approach

    @hi-ogawa
    hi-ogawa committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    15279a2 View commit details
    Browse the repository at this point in the history

  4. test: add more

    @hi-ogawa
    hi-ogawa committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c86c8e6 View commit details
    Browse the repository at this point in the history

  5. avoid lowering earlier if it's not needed

    @evanw
    evanw committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7e4e2d8 View commit details
    Browse the repository at this point in the history