Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound stdout shifting to prevent excessive allocations #941

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Bound stdout shifting to prevent excessive allocations #941

merged 2 commits into from
Mar 10, 2021

Commits on Mar 10, 2021

  1. Bound stdout shifting to prevent excessive allocations 

    I noticed this when using an incremental rebuild. In my project, the `stdout` can grow to 100mb+ during the initial build. During rebuild, the `stdout` is mostly empty. But the old code used an unbounded `slice`, which allocated almost the full 100mb.
    @jridgewell
    jridgewell committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    1da940a View commit details
    Browse the repository at this point in the history

  2. Avoid allocation entirely

    @jridgewell
    jridgewell committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    4a8c867 View commit details
    Browse the repository at this point in the history