Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation string - MQTT Config - Show/Hide advanced settings #17220

Closed
1 task done
zigad opened this issue Nov 12, 2024 · 0 comments · Fixed by #17221
Closed
1 task done

Missing translation string - MQTT Config - Show/Hide advanced settings #17220

zigad opened this issue Nov 12, 2024 · 0 comments · Fixed by #17221
Labels
experimental Experimental feature ux User experience/ interface

Comments

@zigad
Copy link
Contributor

zigad commented Nov 12, 2024

Describe the bug

When editing MQTT settings on web I noticed that the expandable section "Show advanced settings" and "Hide advanced settings" is not translatable. I have already prepared a fix and will open a pull request for you to review.

Screenshot 2024-11-12 at 23 27 36 copy

Steps to reproduce

  1. Open web ui and navigate to MQTT config
  2. open MQTT config in any language except English
  3. Text "Show/Hide advanced settings" is not translated

Configuration details

N/A

Log details

N/A

What type of operating system are you running?

Docker container

Nightly build

  • I have verified that the issue is reproducible with the latest nightly build

Version

0.131.5
zigad added a commit to zigad/evcc that referenced this issue Nov 12, 2024
@zigad
Fix: Make Advanced Settings Text Translatable evcc-io#17220
c365a53 
This will close issue evcc-io#17220
@zigad zigad mentioned this issue Nov 12, 2024
Merged
zigad added a commit to zigad/evcc that referenced this issue Nov 12, 2024
@zigad
Fix: Sort toml evcc-io#17220
9dffb27
zigad added a commit to zigad/evcc that referenced this issue Nov 12, 2024
@zigad
Fix: Make Advanced Settings Text Translatable evcc-io#17220
8ac470f
@naltatis naltatis added ux User experience/ interface experimental Experimental feature labels Nov 12, 2024
zigad added a commit to zigad/evcc that referenced this issue Nov 12, 2024
@zigad
Fix: Make Advanced Settings Text Translatable evcc-io#17220
c9c6077 
Updated so translations are now stored in config.general
naltatis pushed a commit that referenced this issue Nov 12, 2024
@zigad
Fix: Make Advanced Settings Text Translatable #17220 (#17221)
31373f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
experimental Experimental feature ux User experience/ interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Make Advanced Settings Text Translatable #17220 zigad/evcc
2 participants
@naltatis @zigad