-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tesla: allow customizing the command proxy to use #14616
Conversation
I didn't see, that there is another pull request like mine (#14620). But I really think you have to remove the polling of the tesla server each time the current is changed. Otherwise you will hit the API Limit ... |
We indeed need to verify that. My understanding is that the limit of « read » requests is higher and sufficient for our use case. |
According to docs there's an API limit, not a write limit. |
The Limit of Read-Requests ist 200. So it‘s up to the weather, of thats enough or not. |
<> > > I didn't see, that there is another pull request like mine (#14620).
I see what you mean. On the other hand, this data is cached (and not fetched above 6A) so I wonder how many real API call this trigger in a one day. IMHO we should keep the existing logic to avoid issue #13007 coming back, and think of a further fix if we reach the API limits in practice and if that prevent evcc from doing its job properly. |
The Cache is resetted every time current is changing. So in my use case the limit will be reached very fast. 😕 |
Adding a parameter to disable « cleanly » the current check loop. So that we can let the (advanced) user decide. |
Hopefully getting vehicle info should be possible over BLE as well. teslamotors/vehicle-command#229 |
Maybe, but it should not be necessary. The API limits should be fine once you start sending the commands via BLE. |
Yes, but while it isn't an issue for me, there's people without cellular reception at their charging spots. I think I read somewhere Wifi only doesn't work for the API. Could be wrong though. |
As described above this is an issue for my use case. I always charge with < 6A and when there is changing weather the API Limit is reached. Maybe we can try your proposed solution. Perhaps I can file a PR for that. |
Could you check the logs why that happens? We're caching the result and should only call the API if current is updated. That is 2, 3, 4, 5 Amps. Do we even need to call it if the change remains below 6A or only when going from 6A to below? Needs to be tested. |
Another approach would be to check from the charger meter if the actual current consumption match the expected value.
Le lun. 1 juil. 2024 à 16:50, andig ***@***.***(mailto:Le lun. 1 juil. 2024 à 16:50, andig <<a href=)> a écrit :
… Could you check the logs why that happens? We're caching the result and should only call the API if current is updated. That is 2, 3, 4, 5 Amps. Do we even need to call it if the change remains below 6A or only when going from 6A to below? Needs to be tested.
—
Reply to this email directly, [view it on GitHub](#14616 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AET5P3NVMWOHKG4NWN7IQRTZKFUEXAVCNFSM6AAAAABKCQA7RSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGM3DSOJXGQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Actually, we've just added this in #14622. Since the TWC has phase currents, this should work if you remove the |
Mmmmh. Any change needed or is it suppose to already work with twc in latest nightly ? |
Ahhh, I see. Need to check the error return code, too. Change coming. |
@FraBoCH see #14659. It is a bit subtle but should work. Remaining drawback is that we'll only recognize if current is too high by at least 1A, so it might not detect not switching to 5A, but should detect on 4A due to https://github.com/evcc-io/evcc/pull/14622/files#diff-c456526d4bd9022a488ce32de208b40d86016e2c40b0c81a2dffe557c186377dR723. Seems this is the best we can currently do. Ymmv. |
EVCC doesn't always want to use the BLE proxy for me... |
Hi. Try to add a / at the end of your config to match the default value.
Sent from [Proton Mail](https://proton.me/mail/home) for iOS
Le dim. 7 juil. 2024 à 12:21, Vrabetz ***@***.***(mailto:Le dim. 7 juil. 2024 à 12:21, Vrabetz <<a href=)> a écrit :
… EVCC doesn't always want to use the BLE proxy for me...
I have the latest version of EVCC and added
commandProxy: http://192.168.1.52:8080
to my config. But EVCC sometimes still uses EVCC.io to control the charging speed. At least until the limit is reached. The error message even shows the URL as http://tesla.evcc.io... Sorry, but I can't get the logs right now.
Then without me changing anything about the config, it suddenly works. I did restart EVCC a couple of times though.
—
Reply to this email directly, [view it on GitHub](#14616 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AET5P3IC7D5ZVHANMDTHQI3ZLEQCZAVCNFSM6AAAAABKCQA7RSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGQYTIMRVHA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
That's pretty impossible since it will only ever see the configured URL. In any case, trace log would show if that happens. |
Hi everyone, it seems I have the same problem as @Raudi1: Command proxy is set on the vehicles:
commandProxy is a raspi set up with vehicle-command and TeslaBleHttpProxy(working). @andig, can I create an anonymous trace log, or should I send it via email(where to send)? Thanks a lot! |
Pls. post here |
That‘s surprising. I’am using 0.182.1 for two days and charging works perfectly with the proxy. 😃 |
Perhaps something was still cached or something similar? After it started working, it continued to work (at least until some kind of connection issue on the proxy side I had to resolve with a restart of the proxy). |
evcc-20240707-142559-trace.log xxx = VIN Maybe it is a problem with my installation and the problem is on my side... but it seems to have the same problem as @Raudi1 |
Yeah, exactly the same. |
It wont. There is no secret caching. Thanks for the log, will take a look. Is there any indication its using the proxy at all? |
wait a moment, it look pretty good currently. I will observe this for the next hour and report back |
For me there wasn't. The logs for the proxy were completely empty. Just showed the system start and nothing else. After it fixed itself I can see the requests in the proxy log @jannisif try running |
So my setup is working for almost a day.
Sidenote for those having the following problem:
@Raudi1 thank you for your tip, the logs are still unaffected except for several attempts that it sometimes takes to find a connection (the car is 4 m from the raspi). Thank you @wimaha for providing the proxy, it works perfectly with the docker. Have a nice day! |
Hi Andig, I think I may have the exact same issue as Raudi1. I don´t know if it helps but I share you my log and config too. Here are the docker logs for docker logs --since 12h tesla-ble-http-proxy: EVCC Log: My EVCC.Yaml vehicle config: vehicles:
I´ve XXX´d my IP and VIN |
@Nhozz |
@Nhozz you're most likely using a different config file than the one you are editing. To verify, look at the start of the log which shows the config used and then
to verify. Anyway- since this pr has been merged and is confirmed working- I'm closing the discussion here. |
Add support of custom http proxy like https://github.com/wimaha/TeslaBleHttpProxy for sending commands to the standard tesla vehicle template as discussed in #14252.
The corresponding yaml configuration would be: