-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add battery grid charging #14855
Merged
Merged
Add battery grid charging #14855
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f69a4eb
Add grid charge limit
andig 2d3c022
Update server/http.go
andig e95305f
Apply suggestions from code review
andig 2dff437
Refactor to reduce warnings
andig 87a6174
Simplify
andig 3305042
Optimize
andig 74b5dcb
Minimize diff
andig 1b61696
wip
andig 8f76c6a
Add pointer handler
andig 12bc851
wip
andig 4882706
wip
andig df6624d
Update core/site_api.go
andig fe31d88
Fix printing
andig 58a895d
Refactor updating battery mode
andig 95dedf3
wip
andig d2a5002
wip
andig adf5be4
wip
andig 588f400
wip
andig f64eaf5
Lazy- update battery mode
andig 1b45c79
Fix tests
andig 47830ab
Merge branch 'master' into feat/grid-charge
andig 2357955
Fix pointer comparison
andig 14c22f6
wip
andig 6300be7
wip
andig 6f07007
add ui, rename to batterygridcharge
naltatis 80a8163
Merge branch 'master' into feat/grid-charge
naltatis ec7cc82
Fix tests
andig a67d3d6
Rename setting
andig 20a4457
Merge branch 'master' into feat/grid-charge
naltatis 807f3c4
Merge branch 'master' into feat/grid-charge
naltatis 0c23185
layout update
naltatis e4972a0
hide tabs when no grid charge possible
naltatis b68f093
,
naltatis 9c11892
add e2e tests
naltatis 1539c16
Merge branch 'master' into feat/grid-charge
naltatis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich bin noch nicht überzeugt vom Namen. Hier gehts ja "nur" ums Batterie-Laden. Das Smart Cost Limit am LP ist ja auch ein Grid-Charging, aber halt fürs Fahrzeug. Für Symmetrie würd ich
batteryCostLimit
vorschlagen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich find den eigentlich gut. Energie von außen ist günstig und das Feature heisst landläufig Netzladen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hätt gerne die Batterie da mit drin. Gerade weil es ja "nur" die Batterie betrifft. Sonst wird nicht klar, dass es hier nicht um unser "normales laden" geht.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wie wär's mit
batteryGridChargeLimit
?