Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iddfs): make IDDFS more efficient by using IndexSet internally #554

Closed
wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Collaborator

This causes an API change as using an IndexSet requires the type to implement Hash.

This causes an API change as using an `IndexSet` requires the type to
implement `Hash`.
Copy link

codspeed-hq bot commented Mar 24, 2024

CodSpeed Performance Report

Merging #554 will degrade performances by 45.76%

Comparing better-iddfs (c1e8c6c) with main (1ef8a9a)

Summary

❌ 2 regressions
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main better-iddfs Change
fill-corner_to_corner_iddfs 23.1 ms 42.6 ms -45.76%
corner_to_corner_iddfs 8.2 ms 14 ms -41.31%

@samueltardieu
Copy link
Collaborator Author

Clearly less efficient, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant