Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-19933: Fix tests broken by distro resolver #1930

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Jul 5, 2023

EVG-19933

Description

Fix tests broken by app PR.

  • Decommissioning hosts seemed to be passing in update_status_modal.ts, but in fact 0 hosts were being updated because the admin user did not possess necessary permissions. Interestingly, this fails silently so a successful toast was still returned. The scope/role changes in the evergreen PR caused the permissions part to pass, which made the actual update operation fail. I think expecting a failure is fine here.
  • Some tests in the spawn hosts table depended on the order of the table in an unsorted state. This wasn't too useful so I switched these lines to check for the table length (sort tests still pass as expected).

Evergreen PR

evergreen-ci/evergreen#6691

@sophstad sophstad changed the title Fix tests broken by distro resolver EVG-19933: Fix tests broken by distro resolver Jul 5, 2023
@sophstad sophstad marked this pull request as ready for review July 5, 2023 21:56
@cypress
Copy link

cypress bot commented Jul 5, 2023

Passing run #11147 ↗︎

0 564 7 0 Flakiness 0

Details:

Remove tests confirming modal is cleared since we no longer expect a successful ...
Project: Spruce Commit: d2a0b070fe
Status: Passed Duration: 14:31 💡
Started: Jul 7, 2023 3:12 PM Ended: Jul 7, 2023 3:26 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sophstad sophstad merged commit e501680 into evergreen-ci:main Jul 7, 2023
@sophstad sophstad deleted the EVG-19933 branch July 7, 2023 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants