SEAT api change to include main character id #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding main character id from grouping to the response object of the seat API
Altering user controller to add grouping pagination
|
Hi @NoMercy82 thank you for the change. However, to be complete, this PR also need an update on the seat/web repository, on the swagger documentation block from User model. https://github.com/eveseat/web/blob/master/src/Models/User.php Can you check and open another PR on that repo with the new property? |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow callers of the SEAT api access to the main character id of a user.
This is mostly helpful to those who use SEAT internally and have other functions that check across all characters owned by "someone".