Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Structure name. #106

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Added missing Structure name. #106

merged 6 commits into from
Oct 25, 2024

Conversation

MattFalahe
Copy link
Contributor

Added missing structure name in Low fuel and High power. Corrected notification for new application to the corp.

@MattFalahe
Copy link
Contributor Author

Changes were only made in StructureFuelAlert.php, StructureWentHighPower.php and CorpAppNewMsg.php.
All has been tested on my own SeAT.

@recursivetree
Copy link
Contributor

Look good to me. Maybe squash your commit and apply the styleci fixes, and we should be ready to merge.

Added information with structure name

Update StructureWentLowPower.php

StructureWentLowPower.php

Update StructureWentLowPower.php

StructureWentLowPower.php

StructureWentLowPower.php

StructureWentLowPower.php
Added message with structure name

Update StructureLostShields.php

StructureLostShields.php

StructureLostShields.php

StructureLostShields.php

StructureLostShields.php
Added information with structure name

Update StructureLostArmor.php

StructureLostArmor.php

StructureLostArmor.php

StructureLostArmor.php

StructureLostArmor.php
squash

StructureFuelAlert.php

squash

StyleCI

StructureFuelAlert.php

StructureFuelAlert.php

null added

StructureFuelAlert.php

StructureFuelAlert.php

Update StructureFuelAlert.php

Added information name of the structure that is running low on fuel.
squash

StructureWentHighPower.php

squash
StyleCI

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

StructureWentHighPower.php

Added information with structure name
@recursivetree
Copy link
Contributor

Looks good. @Crypta-Eve this can be merged

@Crypta-Eve Crypta-Eve merged commit 93988d2 into eveseat:master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants