Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 link character use main char scopes #678

Conversation

tehraven
Copy link
Contributor

When a User clicks "Link Character" from the top-right menu, they should be prompted to use the same scopes as their Main Character.

The Bug

The DB of refresh_tokens by user_id is not ordered naturally by created_at date, so the "first token" logic being replaced here pulls from a character other than Main Character, which means it will use potentially outdated defaults. Whereas the Main Character, being the one people actually use to Login with, is always prompted to use the newest default scopes that the SeAT Admin has chosen.

This fix allows SeAT Admins to change the default profile and provide an easy way for users with many characters linked to quickly updated all of the scopes across all characters.

Before

  • User has to log out of SeAT, log into SeAT with each and every character manually

After

  • User logs out and logs in with Main character, and then Link Character works fluidly thereafter using the new Scopes for the main character

@tehraven tehraven changed the base branch from master to 5.0.x May 15, 2024 21:04
@Crypta-Eve
Copy link
Member

Is there a reason for the bump in horizon version?

@tehraven
Copy link
Contributor Author

Is there a reason for the bump in horizon version?

The original 5.0 release had supported PHP v7 and that led to some weird composer install outputs while developing a plugin that also tried to bring in module that used PHP 7.

Ref: laravel/horizon@0b1bf46#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L13

@Crypta-Eve Crypta-Eve merged commit 7f489e7 into eveseat:5.0.x May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants