V5 link character use main char scopes #678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a User clicks "Link Character" from the top-right menu, they should be prompted to use the same scopes as their Main Character.
The Bug
The DB of refresh_tokens by user_id is not ordered naturally by created_at date, so the "first token" logic being replaced here pulls from a character other than Main Character, which means it will use potentially outdated defaults. Whereas the Main Character, being the one people actually use to Login with, is always prompted to use the newest default scopes that the SeAT Admin has chosen.
This fix allows SeAT Admins to change the default profile and provide an easy way for users with many characters linked to quickly updated all of the scopes across all characters.
Before
After