-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsEvaluator mResultCallback is growing and do not realease previous callbacks #39
Comments
That's a very good point! I will look at this. Pull request is welcome as well. 👍 |
Yep most cases listeners are small so this make not much harm. But with inner classes can produce bigger leaks. Any way good to hear. I m taking some vacations now... Will follow from September on this. Will contribute than if still valid. Thanks. |
That's good to know, thanks. |
i provided some proposal for change. please letm me know what you think. |
Thank you! I will have a look. |
Thanks @clydzik for fixing the issue. |
np. @evgenyneu thanks for the library! |
i realized that this list is holding results callbacks (probably for matching request/response interface) but as self is not maintained after finish (success or failure)
com.evgenii.jsevaluator.JsEvaluator#mResultCallbacks
the workaround is to use
jsEvaluator.getResultCallbacks().remove();
but this is not documented and a bit awkward
The text was updated successfully, but these errors were encountered: