-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress logs for templated pages #1859
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Epic, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorely needed feature!
What's the current UX for using this plugin with npm run build
packages/lib/plugin-connector/src/build-plugins/verbose-logs/index.js
Outdated
Show resolved
Hide resolved
[wip]Goal: Forked childprocess tracks the progess on each template file (route) After the modules are transformed, the childprocess's stdout is shown on the terminal, while the parent's stdout is redirected to log file in /tmp so that the logs from the parent doesn't ruin the UI. Happens at the very last stage of the build process. Should I progress further or is it complicating a very trivial thing? Code_BlC1iEwrAx.mp4 |
My instinct is this is a lot of additional LoC and some more deps for a useful, but not essential feature. Is there a simpler approach we can run using something like fs or chokidar - existing dep? If it makes it easier, I'm not sure it's essential to know "percentage complete" vs just the number of pages built so far |
✅ Deploy Preview for next-docs-evidence ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
56e04e9
to
e536983
Compare
everything with one watcher
GmbZnTIRWf.mp4 |
Big fan of this feature - overall this PR looks good, but I don't think the plugin connector is the best place to land it. Need to think on this a bit more to figure out where to slot it |
I've logged this as an issue in #2258, I'm going to close this until it can be re-addressed in that issue, but this is a great feature and we appreciate the submission! |
Description
#1852
Implement feature as a Vite plugin to count markdown files in the pages directory and compare them with the number of pages built during the Vite build process. This will provide the build progression percentage specifically for templated pages.