Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing installation on Windows + MSYS #179

Merged
merged 1 commit into from
May 4, 2021
Merged

fix: failing installation on Windows + MSYS #179

merged 1 commit into from
May 4, 2021

Conversation

akiver
Copy link
Contributor

@akiver akiver commented May 4, 2021

Hi!

Since version 0.7.3, the installation on Windows + Git Bash for NodeJS projects fails.
Git Bash uses the bash MSYS and the lefthook script doesn't support it, failure output example:

# echo "${OS} ${ARCH}"
MSYS_NT-10.0-19043 x86_64

Unsupported OS: MSYS_NT-10.0-19043

This patch fixes this issue.
Thank you

@Envek Envek self-assigned this May 4, 2021
@Envek Envek added Windows Windows case packaging/npm Problem specific to NPM wrapper for Nodejs labels May 4, 2021
@Envek Envek merged commit bc2c5cb into evilmartians:master May 4, 2021
@Envek
Copy link
Member

Envek commented May 4, 2021

Thank you very much! There are so many flavors of development environments on Windows, so hard to cover everything.

Envek added a commit that referenced this pull request May 4, 2021
@Envek
Fix failing installation of NPM package on Windows + MINGW64
cacd3b7 
Follow-up for #179
@Envek
Copy link
Member

Envek commented May 14, 2021

Released in 0.7.5. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Envek Envek

Labels
packaging/npm Problem specific to NPM wrapper for Nodejs Windows Windows case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akiver @Envek