Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #275

Merged
merged 45 commits into from
Jun 17, 2022
Merged

Refactoring #275

merged 45 commits into from
Jun 17, 2022

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Jun 9, 2022 •
edited
Loading

This refactoring is aimed to the following:

  • Reorganized the code for convenience
  • Make the code testable, increase test coverage
  • Make the code easier to maintain
  • Create config structure and make working with configuration less chaotic

skryukov and others added 30 commits October 12, 2021 10:38
@skryukov
Refactoring WIP
e055dc9
@mrexox
Read configuration into memory
2182443 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Move list of hooks to config
f3dd673 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox @skryukov
Implement config loading and add tests (#245)
accb87a 
* Implement config loading and add tests

Signed-off-by: Valentin Kiselev <[email protected]>

* Use viper for merging configs and also keep handling {cmd}

Signed-off-by: Valentin Kiselev <[email protected]>

* Bump libgit2 and refactor load.go

Signed-off-by: Valentin Kiselev <[email protected]>

* Improve extends algorithm, remove dummy func replaceCmd

Co-authored-by: Svyatoslav Kryukov <[email protected]>
@mrexox
Bump libgit2 and refactor load.go
0ebf449 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Improve extends algorithm, remove dummy func replaceCmd
7aeb9d3 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Implement install command
35d1a15 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Fix typo
1f5836f 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Hide unneeded logs under verbose flag
eaefe70 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Move logic to a separate package
a23b804 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Move deprecated option 'aggressive' to uninstall command
4d5776f 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Cover install command with tests
c02966f 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Add tests on install and uninstall commands
01d26f8 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Fix lefthook file detection
92de212 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Configure CI linter
6a472e7 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Bump go to 1.17
2268393 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Try fix golangci-lint in github actions
8289896 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Improve logging
5e4b5e2 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Use more understandable patterns for Lefthook initialization
9ec226c 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Implement add command and refactor some other files and tests
5878866 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Update the list of git hooks
4556baa 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Add more linters and fix issues
360128f 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Store checksum file name in one place
baa238e 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Fix comments
2ab9b24 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Embed documentation from a file
c5e3afb 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Prepare a skeleton for Run command implementation
adda4aa 
Signed-off-by: Valentin Kiselev <[email protected]>
@markovichecha @mrexox
Run command implementation
f3ffc5b
@markovichecha @mrexox
review fixes
5eff2e6
@markovichecha @mrexox
more tweaks
b3f5982
@markovichecha @mrexox
filesTypeToFn
6802534
markovichecha and others added 9 commits June 9, 2022 10:25
@markovichecha @mrexox
run command windows
02e6c56
@markovichecha @mrexox
build flag for windows
f30499f
@mrexox
fix(ci): Fix goreleaser build
7c3c434 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Reorganize files for better code support
44c0acd 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Implement version check, refactor tests
d643c2d 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Try fixing tests on windows
015b891 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Fix linter
9f7d359 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Don't execute a command if substitution is empty
d2c4bd8 
Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox
Merge branch 'master' into refactoring
466e801 
* master:
  Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip]
  Include version into RPM/DEB packages on release [ci skip]
  0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package
  Split NPM package to two: bundled and installer (#273)
  Include archived binaries in the releases (#189)
  docs: s/agrs/args (#265) [ci skip]
  chore(lint): Fix golangci-lint complains
  docs(usage): Add commitlint example in full_guide (#201)
  Fix unreachable conditional in hook template (#242)
  fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260)
  Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263)
  Fix typo in docs/full_guide.md (#256)
  0.7.7: Fix arguments passing and various NPM-related fixes
  Fix incorrect npx command in git hook script template (#236)
  Update project URLs in NPM package.json (#235)
  Pass all arguments to downstream hooks (#231)
  Allows lefthook to work when node_modules is not in root folder for npx (#224)
  Do not initialize git config on `help` and `version` commands (#209)
  node: fix postinstall: process.cwd is a function and should be called

Signed-off-by: Valentin Kiselev <[email protected]>
@mrexox mrexox marked this pull request as ready for review June 9, 2022 07:49
@mrexox mrexox requested a review from skryukov June 9, 2022 07:49
@mrexox mrexox merged commit bfed65c into master Jun 17, 2022
@mrexox mrexox deleted the refactoring branch June 18, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skryukov skryukov Awaiting requested review from skryukov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrexox @skryukov @markovichecha