Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skipping empty summaries #531

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

technicalpickles
Copy link
Contributor

@technicalpickles technicalpickles commented Jul 26, 2023

Closes #530

⚡ Summary

Add empty_summary to values of skip_output for those cases when there's commands to run for a hook (ie all have been skipped, or there's no files matching command patterns)

☑️ Checklist

  • Check locally
  • Add tests
  • Update documentation

Copy link
Member

@mrexox mrexox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels good, thank you! Do you want to also update the docs? If not, I can merge the PR and do it for you :)

@technicalpickles
Copy link
Contributor Author

@mrexox I can update the docs, I mostly wanted to get a 👍🏻 before doing it 😅

I'm not sure why the coverage is failing though. I did not think there was much in the way of tests to actually make sure the output is skipped, so I didn't have anything to crib.

@mrexox
Copy link
Member

mrexox commented Jul 27, 2023

No problem, it's just integration tests, they are not supposed to cover all possible cases.

@technicalpickles
Copy link
Contributor Author

Added! I didn't see much else to document except in the skip_output section.

Feel free to make any other changes needed to land, but I'm also happy to do so.

@mrexox mrexox merged commit f8d3e85 into evilmartians:master Jul 27, 2023
8 checks passed
@mrexox
Copy link
Member

mrexox commented Jul 27, 2023

Thank you a lot! I am going to close this issue before creating a new release, so I hope to release this change next week.

@technicalpickles technicalpickles deleted the skip_empty_summary branch July 27, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipping output for SUMMARY: (SKIP EMPTY)
2 participants