chore(npm): use bin.sh for execute
#798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve few issues related to bun and it has a `bunx`/`npx` support compared to evilmartians#705 This approach does not work on `pnpm` and does not reduce startup time. For `npx` it is faster but not much, for `bunx` it is marginally faster
|
@mrexox I was not able to test locally, but really ready to test if you provide any way to test locally for |
mrexox
reviewed
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues and PR: #688, #703, #705, #776
And #794, #796
⚡ Summary
Reduce execution startup time
This should solve few issues related to bun and it has a
bunx/npxsupport compared to #705This script,
bin.shexecutes only as later it will be replaced to actualbinaryfileThis approach does not work on
pnpmand does not reduce startup time. Fornpxit is faster but not much, forbunxit is marginally faster☑️ Checklist