-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember 2.0 support #52
Conversation
0724917
to
567e08c
Compare
"<li>{{component-render a=a b=b c=c d=d}}</li>" + | ||
"<li>{{component-render a=a b=b c=c d=d}}</li>" + | ||
"{{#each data.items as |item|}}" + | ||
"<li>{{buffer-render data=a}} {{buffer-render data=item.b}} {{buffer-render data=item.c}} {{buffer-render data=item.d}}</li>" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be data=item.a
567e08c
to
4dd28b4
Compare
4dd28b4
to
a323a10
Compare
I've gathered results from before and after this PR to ensure that we're still capturing the slowdown and subsequent speed improvements in initial render performance: https://docs.google.com/spreadsheets/d/15MPfzCncD_PvM-nmfdrA-_UsUzNpAVV9pFkt3wU5rBo/edit?usp=sharing The new tests seem to be capturing this correctly (master on the left, #52 on the right): |
/cc @eviltrout I've got some time this week to continue to work on ember-performance. It would be great if you could take a look at this, thanks |
This looks excellent, I will merge now :) |
closes #51
This updates the tests to run on Ember 1.11 -> Ember 2.0. I've implemented a new RenderTemplateTestClient which allows for simple tests such as:
I've dropped versions earlier than Ember 1.11 as they would require separate templates.