Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 2.0 support #52

Merged
merged 1 commit into from
Sep 16, 2015
Merged

Ember 2.0 support #52

merged 1 commit into from
Sep 16, 2015

Conversation

GavinJoyce
Copy link
Collaborator

closes #51

This updates the tests to run on Ember 1.11 -> Ember 2.0. I've implemented a new RenderTemplateTestClient which allows for simple tests such as:

(function() {
  var template = "hi {{name}}";

  RenderTemplateTestClient.run({
    name: 'Render simple attribute',

    setup: function() {
      this.setupTemplateTest(template, { name: 'Ben' });
    },

    reset: function() {
      this.hideComponent();
    },

    test: function() {
      this.showComponent();
    }
  });
})();

I've dropped versions earlier than Ember 1.11 as they would require separate templates.

@GavinJoyce GavinJoyce changed the title [WIP] Ember 2.0 support Ember 2.0 support Sep 15, 2015
@GavinJoyce GavinJoyce mentioned this pull request Sep 15, 2015
"<li>{{component-render a=a b=b c=c d=d}}</li>" +
"<li>{{component-render a=a b=b c=c d=d}}</li>" +
"{{#each data.items as |item|}}" +
"<li>{{buffer-render data=a}} {{buffer-render data=item.b}} {{buffer-render data=item.c}} {{buffer-render data=item.d}}</li>" +
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be data=item.a

@GavinJoyce
Copy link
Collaborator Author

I've gathered results from before and after this PR to ensure that we're still capturing the slowdown and subsequent speed improvements in initial render performance:

https://docs.google.com/spreadsheets/d/15MPfzCncD_PvM-nmfdrA-_UsUzNpAVV9pFkt3wU5rBo/edit?usp=sharing

The new tests seem to be capturing this correctly (master on the left, #52 on the right):

image

@GavinJoyce
Copy link
Collaborator Author

/cc @eviltrout I've got some time this week to continue to work on ember-performance. It would be great if you could take a look at this, thanks

@eviltrout
Copy link
Owner

This looks excellent, I will merge now :)

eviltrout added a commit that referenced this pull request Sep 16, 2015
@eviltrout eviltrout merged commit 0dd4871 into eviltrout:master Sep 16, 2015
@GavinJoyce GavinJoyce deleted the gj/ember-2.0 branch September 16, 2015 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Ember 2.0+
2 participants