Problem: cannot generate ledger address

[leejw51crypto]

ethermintd keys add my --ledger

Error: address  rejected

[leejw51crypto]

after clear this issue, try signing as well

[fedekunze]

opened an issue on SDK: cosmos/cosmos-sdk#9734

[leejw51crypto]

started
i will try with cosmos ledger app first.

[leejw51crypto]

work plan

1. check with cosmos ledger app
2. check with ethereum ledger app

[leejw51crypto]

option 1 not working , because of

118 is hard-coded for generating address, also signing

[leejw51crypto]

generating, signing with ledger working good with testing program.
using go-ethereum, package

import 	"github.com/ethereum/go-ethereum/accounts/usbwallet"

adding this code now

to change cosmos level, need to override

https://github.com/cosmos/ledger-cosmos-go

and fix this interface to ethereum style, just 4 functions
replace with go-ethereum/usbwallet
then current cosmos command will work , too. (for ledger)

	SECP256K1 interface {
		Close() error
		// Returns an uncompressed pubkey
		GetPublicKeySECP256K1([]uint32) ([]byte, error)
		// Returns a compressed pubkey and bech32 address (requires user confirmation)
		GetAddressPubKeySECP256K1([]uint32, string) ([]byte, string, error)
		// Signs a message (requires user confirmation)
		SignSECP256K1([]uint32, []byte) ([]byte, error)
	}

[fedekunze]

Can we create an ADR for this so that I can share it with @jleni and propose either additional changes or create a new ledger application?

[leejw51crypto]

ok, i'll create adr
to resolve go-ethereum usbwallet and cosmos ledger colision

build ethermintd with ethereum ledger code

go build  -tags cgo,ledger --ldflags "-extldflags \"-Wl,--allow-multiple-definition\"" .\cmd\ethermintd

for launch.json

    {
      "name": "Add Ledger",
      "type": "go",
      "request": "launch",
      "mode": "auto",
      "program": "${workspaceFolder}/cmd/ethermintd",
      "env": {
        "KEY": "mykey",
        "CHAINID": "ethermint-2",
        "MONIKER": "localtestnet",
        "KEYRING": "test",
        "KEYALGO": "eth_secp256k1",
        "LOGLEVEL": "fatal",
        "TRACE": ""
      },
      "args": [
        "keys",
        "add",
        "myledger0",
        "--keyring-backend",
        "test",
        "--ledger"
      ],
      "buildFlags": "-tags='cgo,ledger' --ldflags '-extldflags '-Wl,--allow-multiple-definition''"
    }

[leejw51crypto]

used
signer := ethtypes.NewEIP2930Signer(args.ChainID.ToInt())

and directly give txfound to tx-builder

chainid := ethSigner.ChainID()
	txfound, err := wallet0.SignTx(accounts[0], tx, chainid)
	msg.FromEthereumTx(txfound)

and double checked

	sender3, _ := ethSigner.Sender(tx3)

[leejw51crypto]

in code-review

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.