Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

evm: PostTxProcessing hook - include the full message data #1027

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

loredanacirstea
Copy link
Contributor

Closes: #XXX

Description

Give access to both message and receipt in the PostTxProcessing hook.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@loredanacirstea loredanacirstea changed the title x/evm - PostTxProcessing use message as callback input evm: PostTxProcessing hook - include the full message data Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1027 (3fc3907) into main (6abe84b) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1027   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files          80       80           
  Lines        6577     6577           
=======================================
  Hits         3891     3891           
  Misses       2467     2467           
  Partials      219      219           
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 75.61% <0.00%> (ø)
x/evm/keeper/hooks.go 100.00% <100.00%> (ø)
x/evm/keeper/keeper.go 78.70% <100.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we change the ethtype.Message to core.Message? See comment

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved
@fedekunze
Copy link
Contributor

the linter error seems unrelated, I'll investigate and fix in another PR

@fedekunze fedekunze merged commit cc37ed2 into evmos:main Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants