This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
analytics(app): update telemetry to Ethermint modules #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-422 Add Observability (telemetry) on Ethermint
Add Gauges and counters specially on the fee market module to track changes in the BaseFee, block gas, tx refunds, etc |
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
+ Coverage 61.25% 61.36% +0.10%
==========================================
Files 88 88
Lines 7194 7213 +19
==========================================
+ Hits 4407 4426 +19
Misses 2563 2563
Partials 224 224
|
danburck
changed the title
danburck
changed the title
danburck
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
fedekunze
approved these changes
Jun 2, 2022
crypto-facs
approved these changes
Jun 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds telemetry to Ethermint modules and is an advancement of the recent telemetry implementation on Evmos.
Metrics
I implemented the following metrics to observe. They still need to be added to the respective specs that use Ethermint:
feemarket_base_feefeemarket_block_gastx_msg_ethereum_tx_gas_limit_per_gas_used