Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

min-gas-multiplier parameter should accept zero value #1120

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jun 9, 2022

Description

update min-gas-multiplier validation logic


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

update min-gas-multiplier validation logic
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1120 (4a515ae) into main (b567624) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1120   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          88       88           
  Lines        7285     7285           
=======================================
  Hits         4507     4507           
  Misses       2557     2557           
  Partials      221      221           
Impacted Files Coverage Δ
types/account.go 26.31% <100.00%> (ø)
x/feemarket/types/params.go 93.10% <100.00%> (ø)

Copy link
Contributor

@crypto-facs crypto-facs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Forgot to update this from the divider version 🙏

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry?

@yihuang
Copy link
Contributor Author

yihuang commented Jun 9, 2022

ACK, can you add a changelog entry?

done

@fedekunze fedekunze merged commit 8283530 into evmos:main Jun 9, 2022
@yihuang yihuang deleted the fix-multipler-validation branch June 9, 2022 09:26
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Jun 10, 2022
…evmos#1120)

* min-gas-multiplier parameter should accept zero value

update min-gas-multiplier validation logic

* fix unit test

* changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants