Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

optimize eth_getBalance endpoint #1169

Merged
merged 5 commits into from
Jul 11, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

small PR to optimize eth_getBalance rpc endpoint


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Freddy! Can you add a bug fix changelog entry?

rpc/backend/evm_backend.go Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) July 11, 2022 14:59
@fedekunze fedekunze merged commit da8fcc3 into evmos:main Jul 11, 2022
danburck pushed a commit that referenced this pull request Jul 12, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck pushed a commit that referenced this pull request Jul 12, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck pushed a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck pushed a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck pushed a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck pushed a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck added a commit that referenced this pull request Jul 13, 2022
* fix(rpc): optimize `eth_getBalance` endpoint (#1169)

* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* add backport changes

Co-authored-by: crypto-facs <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck added a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Co-authored-by: crypto-facs <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck added a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Co-authored-by: crypto-facs <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
danburck added a commit that referenced this pull request Jul 13, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Co-authored-by: crypto-facs <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Co-authored-by: crypto-facs <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to devon-chain/ethermint that referenced this pull request Aug 2, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants