Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: traceTransaction returns zero gas used (backport #1179) #1200

Closed
wants to merge 3 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 25, 2022

This is an automatic backport of pull request #1179 done by Mergify.
Cherry-pick of b74b37f has failed:

On branch mergify/bp/release/v0.17.x/pr-1179
Your branch is up to date with 'origin/release/v0.17.x'.

You are currently cherry-picking commit b74b37f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	modified:   x/evm/keeper/state_transition.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/evm/keeper/grpc_query_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Problem: traceTransaction returns zero gas used

Solution:
- call CaptureTxStart and CaptureTxEnd

* fix trace unit tests

* add overflow check

* add comment

* check gas used is positive

* Update x/evm/keeper/state_transition.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit b74b37f)

# Conflicts:
#	x/evm/keeper/grpc_query_test.go
@fedekunze fedekunze closed this Jul 25, 2022
@fedekunze fedekunze deleted the mergify/bp/release/v0.17.x/pr-1179 branch July 25, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants