Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Cherry pick latest changes #1265

Merged
merged 10 commits into from
Aug 13, 2022
Merged

Cherry pick latest changes #1265

merged 10 commits into from
Aug 13, 2022

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Aug 12, 2022

Closes: #XXX

Description

Adding the following changes:


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

facs95 and others added 2 commits August 12, 2022 15:54
…gh (#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <[email protected]>
@facs95 facs95 marked this pull request as draft August 12, 2022 20:37
danburck and others added 3 commits August 12, 2022 16:43
* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <[email protected]>
@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Aug 12, 2022
@facs95 facs95 marked this pull request as ready for review August 12, 2022 20:48
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1265 (081b726) into release/v0.19.x (5ffe4ca) will decrease coverage by 0.08%.
The diff coverage is 37.07%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.19.x    #1265      +/-   ##
===================================================
- Coverage            51.29%   51.20%   -0.09%     
===================================================
  Files                  102      103       +1     
  Lines                 9194     9352     +158     
===================================================
+ Hits                  4716     4789      +73     
- Misses                4235     4304      +69     
- Partials               243      259      +16     
Impacted Files Coverage Δ
rpc/backend/account_info.go 0.00% <0.00%> (ø)
rpc/backend/node_info.go 0.00% <0.00%> (ø)
rpc/backend/tracing.go 0.00% <0.00%> (ø)
rpc/backend/tx_info.go 0.00% <0.00%> (ø)
rpc/backend/utils.go 1.29% <ø> (-2.50%) ⬇️
rpc/types/utils.go 0.00% <0.00%> (ø)
rpc/types/events.go 71.85% <50.00%> (-16.25%) ⬇️
server/config/config.go 22.48% <50.00%> (+0.32%) ⬆️
indexer/kv_indexer.go 64.96% <64.96%> (ø)
rpc/backend/backend.go 53.57% <100.00%> (+1.71%) ⬆️
... and 3 more

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 3762738 into release/v0.19.x Aug 13, 2022
@fedekunze fedekunze deleted the cherry-pick branch August 13, 2022 10:00
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
* changelog

* Add support for miner_setGasPrice API (evmos#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <[email protected]>

* tests(rpc): add filter tests (evmos#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
* changelog

* Add support for miner_setGasPrice API (evmos#1237)

* fix kv indexer unit test

* fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239)

* Problem: get_proof test fail because block numbers are not high enough

Solution:
- wait for app block height rather than tendermint block height

* Update tests/integration_tests/test_types.py

* keep get_proof response the same as geth

Co-authored-by: Daniel Burckhardt <[email protected]>

* tests(rpc): add filter tests (evmos#1233)

* tests(rpc): add pending transaction filter test

* tests(rpc): add block filter and event log  test

* tests(rpc): simplify to cluster instead of comparing types

* tests(rpc): wip filter by address

* tests(rpc): add get_logs test

* fix flake8 linter

* fix flake8 linter

* add caching to readme

* add caching to readme

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* changelog

* update gomod2nix

* fix python linter

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit 3762738)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants