This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facs95
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
August 12, 2022 19:32
…gh (#1239) * Problem: get_proof test fail because block numbers are not high enough Solution: - wait for app block height rather than tendermint block height * Update tests/integration_tests/test_types.py * keep get_proof response the same as geth Co-authored-by: Daniel Burckhardt <[email protected]>
* tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/v0.19.x #1265 +/- ##
===================================================
- Coverage 51.29% 51.20% -0.09%
===================================================
Files 102 103 +1
Lines 9194 9352 +158
===================================================
+ Hits 4716 4789 +73
- Misses 4235 4304 +69
- Partials 243 259 +16
|
fedekunze
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Aug 17, 2022
* changelog * Add support for miner_setGasPrice API (evmos#1237) * fix kv indexer unit test * fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239) * Problem: get_proof test fail because block numbers are not high enough Solution: - wait for app block height rather than tendermint block height * Update tests/integration_tests/test_types.py * keep get_proof response the same as geth Co-authored-by: Daniel Burckhardt <[email protected]> * tests(rpc): add filter tests (evmos#1233) * tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]> * changelog * update gomod2nix * fix python linter * Apply suggestions from code review * Update CHANGELOG.md Co-authored-by: yihuang <[email protected]> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain
pushed a commit
to PundiAI/ethermint
that referenced
this pull request
Nov 17, 2022
* changelog * Add support for miner_setGasPrice API (evmos#1237) * fix kv indexer unit test * fix(rpc): get_proof test fail because block numbers are not high enough (evmos#1239) * Problem: get_proof test fail because block numbers are not high enough Solution: - wait for app block height rather than tendermint block height * Update tests/integration_tests/test_types.py * keep get_proof response the same as geth Co-authored-by: Daniel Burckhardt <[email protected]> * tests(rpc): add filter tests (evmos#1233) * tests(rpc): add pending transaction filter test * tests(rpc): add block filter and event log test * tests(rpc): simplify to cluster instead of comparing types * tests(rpc): wip filter by address * tests(rpc): add get_logs test * fix flake8 linter * fix flake8 linter * add caching to readme * add caching to readme Co-authored-by: Federico Kunze Küllmer <[email protected]> * changelog * update gomod2nix * fix python linter * Apply suggestions from code review * Update CHANGELOG.md Co-authored-by: yihuang <[email protected]> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 3762738)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Adding the following changes:
miner_setGasPrice
API #1237For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)