-
Notifications
You must be signed in to change notification settings - Fork 561
feat: add txpool namespace RPC methods #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you also add the txpool_inspect
and txpool_status
endpoints to return empty values? See https://geth.ethereum.org/docs/rpc/ns-txpool
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Hey @fedekunze thanks for the review! Just added the other two endpoints with a similar approach. Feel free to give it a final look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Can you also add a description on de CHANGELOG.md with the issue number and description under the Unreleased > Improvements
section?
follow up issue, add tests for RPC and documentation of the RPC endpoint |
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 68.81% 69.67% +0.85%
==========================================
Files 5 5
Lines 635 643 +8
==========================================
+ Hits 437 448 +11
+ Misses 183 179 -4
- Partials 15 16 +1
|
Closes: #124
Description
Enabled txpool namespace with
txpool_content
method that complies with the go ethereum documentation. The decision was to return an empty response (this is explained in further detail in the issue). Endpoint is needed to unblock block explorer integrationNOTE: Did not update documentation as the method is not fully functional yet. Happy to do it if it is required.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)