Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(tests): avoid error when run benchmark #1573

Merged
merged 3 commits into from
Dec 27, 2022

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Dec 26, 2022

Closes: #XXX

Description

pass testing.B when set up test to avoid nil pointer error when run go test -bench ^BenchmarkMessageCall$ github.com/evmos/ethermint/x/evm/keeper


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from a team as a code owner December 26, 2022 14:46
@mmsqe mmsqe requested review from Vvaradinov and 4rgon4ut and removed request for a team December 26, 2022 14:46
@fedekunze fedekunze enabled auto-merge (squash) December 27, 2022 17:52
@fedekunze fedekunze merged commit 7b4c1d9 into evmos:main Dec 27, 2022
mmsqe added a commit to mmsqe/ethermint that referenced this pull request Mar 7, 2023
* avoid error when run benchmark

* fix rest benchmark test

Co-authored-by: Federico Kunze Küllmer <[email protected]>
yihuang added a commit to crypto-org-chain/ethermint that referenced this pull request Mar 7, 2023
* nix-action fail in CI

* fix: build test on mac by updating to python3.10 (evmos#1437)

* fix: unstable tx_priority test (evmos#1440)

* fix unstable tx_priority test

* Update tests/integration_tests/test_priority.py

Co-authored-by: yihuang <[email protected]>

* Update tests/integration_tests/test_priority.py

Co-authored-by: yihuang <[email protected]>

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Adi Saravanan <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* fix: enable `fixIssue172` flag for non-deterministic keyring test (evmos#1447)

* enable fixIssue172 flag for test

for more info, https://github.com/btcsuite/btcutil/pull/182/files

* fix import

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Adi Saravanan <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>

* fix(tests): avoid error when run benchmark (evmos#1573)

* avoid error when run benchmark

* fix rest benchmark test

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* fix resolve

---------

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Adi Saravanan <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants