feat: support stateful precompiled contracts #1650

mmsqe · 2023-02-01T01:03:57Z

Updates: #1116

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

…ecompiles

temp temp fix build temp fix build support mint method mint and query balance

x/evm/keeper/state_transition.go

+	for addr, creator := range k.customPrecompiles {
+		contracts[addr] = creator(ctx, stateDB, caller, msg.Value(), false)
+	}


x/evm/keeper/precompiles/bank.go

+
+func init() {
+	addressType, _ := abi.NewType("address", "", nil)
+	uint256Type, _ := abi.NewType("uint256", "", nil)


x/evm/keeper/precompiles/bank.go

+)
+
+func init() {
+	addressType, _ := abi.NewType("address", "", nil)


x/evm/keeper/state_transition.go

x/evm/keeper/precompiles/bank.go

x/evm/keeper/state_transition.go

+	for addr, c := range contracts {
+		precompiles[addr] = c
+	}


x/evm/keeper/state_transition.go

+	for addr, creator := range k.customPrecompiles {
+		contracts[addr] = creator(ctx, stateDB, caller, msg.Value(), false)
+	}


x/evm/keeper/state_transition.go

x/evm/keeper/precompiles/bank.go

x/evm/keeper/state_transition.go

x/evm/keeper/precompiles/bank.go

x/evm/keeper/precompiles/utils.go

x/evm/keeper/state_transition.go

for more info: https://github.com/evmos/go-ethereum/blob/v1.10.26-evmos-rc1/core/vm/contracts.go#L204 https://github.com/evmos/go-ethereum/blob/v1.10.26-evmos-rc1/core/vm/contract.go#L29

x/evm/keeper/state_transition.go

x/evm/keeper/precompiles/transfer.go

store/cachemulti/store.go

tests/integration_tests/test_precompiles.py

github-actions · 2023-04-08T00:17:38Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

yihuang · 2023-04-13T02:08:45Z

x/evm/statedb/statedb.go

 // Keeper returns the underlying `Keeper`
 func (s *StateDB) Keeper() Keeper {
 	return s.keeper
 }

+// AppendJournalEntry allow external module to append journal entry,
+// to support snapshot revert for external states.
+func (s *StateDB) AppendJournalEntry(entry JournalEntry) {


Is this method used anywhere?

No, can clean up some interface now

codecov · 2023-04-13T08:20:37Z

Codecov Report

Merging #1650 (5377940) into main (382a6ae) will decrease coverage by 0.18%.
The diff coverage is 54.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1650      +/-   ##
==========================================
- Coverage   68.89%   68.72%   -0.18%     
==========================================
  Files         117      119       +2     
  Lines       10681    10726      +45     
==========================================
+ Hits         7359     7371      +12     
- Misses       2900     2931      +31     
- Partials      422      424       +2

Impacted Files	Coverage Δ
client/bank.go	`0.00% <0.00%> (ø)`
x/evm/statedb/native.go	`0.00% <0.00%> (ø)`
x/evm/types/tracer.go	`7.14% <0.00%> (ø)`
x/evm/statedb/statedb.go	`91.30% <8.33%> (-7.91%)`	⬇️
app/ante/eth.go	`80.00% <100.00%> (-0.18%)`	⬇️
app/app.go	`85.04% <100.00%> (-0.03%)`	⬇️
x/evm/keeper/keeper.go	`87.13% <100.00%> (-0.15%)`	⬇️
x/evm/keeper/state_transition.go	`79.63% <100.00%> (+1.25%)`	⬆️

replace transfer with raw

x/evm/keeper/precompiles/bank.go

+func init() {
+	addressType, _ := abi.NewType("address", "", nil)
+	uint256Type, _ := abi.NewType("uint256", "", nil)
+	bytesType, _ := abi.NewType("bytes", "", nil)


x/evm/keeper/precompiles/bank.go

+
+func init() {
+	addressType, _ := abi.NewType("address", "", nil)
+	uint256Type, _ := abi.NewType("uint256", "", nil)


x/evm/keeper/precompiles/bank.go

+)
+
+func init() {
+	addressType, _ := abi.NewType("address", "", nil)


github-actions · 2023-06-02T01:44:04Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

yihuang and others added 3 commits February 1, 2023 08:53

demonstrate use new cache store clone to integrate native stateful pr…

dae19d4

…ecompiles

fix to BenchmarkMessageCall

76d65bf

Bank precompiled contract

869b33f

temp temp fix build temp fix build support mint method mint and query balance

github-advanced-security bot found potential problems Feb 1, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/precompiles/bank.go Fixed Show fixed Hide fixed

x/evm/keeper/precompiles/bank.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 1, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

mmsqe added 3 commits February 1, 2023 20:55

replace extStates commit with executeNativeAction

b6007dc

avoid inject precompile contracts

a98437d

avoid fork

bb913f1

mmsqe force-pushed the precompiled branch from 967323f to bb913f1 Compare February 1, 2023 12:56

github-advanced-security bot found potential problems Feb 1, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/precompiles/bank.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 1, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/precompiles/bank.go Fixed Show fixed Hide fixed

mmsqe force-pushed the precompiled branch from 7729ebb to f834a85 Compare February 3, 2023 02:06

github-advanced-security bot found potential problems Feb 3, 2023

View reviewed changes

x/evm/keeper/precompiles/utils.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 3, 2023

View reviewed changes

x/evm/keeper/precompiles/utils.go Fixed Show fixed Hide fixed

mmsqe force-pushed the precompiled branch from f834a85 to d1670ac Compare February 3, 2023 14:36

github-advanced-security bot found potential problems Feb 3, 2023

View reviewed changes

x/evm/keeper/precompiles/utils.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 3, 2023

View reviewed changes

x/evm/keeper/precompiles/utils.go Fixed Show fixed Hide fixed

mmsqe added 3 commits February 3, 2023 23:04

check readonly per run instead of contract

f8bac9b

test delegatecall

aa03962

Merge branch 'main' into precompiled

c074d40

mmsqe force-pushed the precompiled branch from d1670ac to c074d40 Compare February 3, 2023 15:06

mmsqe added 3 commits February 4, 2023 22:13

test delegatecall

4337fb4

update geth

a740db1

sort contracts by asc

13d1ec9

github-advanced-security bot found potential problems Feb 4, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 4, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

replace with precompile list

46b69f9

for more info: https://github.com/evmos/go-ethereum/blob/v1.10.26-evmos-rc1/core/vm/contracts.go#L204 https://github.com/evmos/go-ethereum/blob/v1.10.26-evmos-rc1/core/vm/contract.go#L29

github-advanced-security bot found potential problems Feb 6, 2023

View reviewed changes

x/evm/keeper/state_transition.go Fixed Show fixed Hide fixed

x/evm/keeper/precompiles/transfer.go Fixed Show fixed Hide fixed

x/evm/keeper/precompiles/transfer.go Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 20, 2023

View reviewed changes

store/cachemulti/store.go Fixed Show fixed Hide fixed

store/cachemulti/store.go Fixed Show fixed Hide fixed

store/cachemulti/store.go Fixed Show fixed Hide fixed

store/cachemulti/store.go Fixed Show fixed Hide fixed

store/cachemulti/store.go Fixed Show fixed Hide fixed

fix nix

54091f4

github-advanced-security bot found potential problems Feb 20, 2023

View reviewed changes

mmsqe added 2 commits February 21, 2023 09:34

fix crc20 <-> native token

692e69f

test delegate & static call

6f5ac41

github-advanced-security bot found potential problems Feb 21, 2023

View reviewed changes

tests/integration_tests/test_precompiles.py Fixed Show fixed Hide fixed

tests/integration_tests/test_precompiles.py Fixed Show fixed Hide fixed

fix lint

c0804be

yihuang mentioned this pull request Mar 1, 2023

adr: draft ADR for stateful precompiled contracts #1131

Closed

11 tasks

github-actions bot added the Status: Stale label Apr 8, 2023

yihuang reviewed Apr 13, 2023

View reviewed changes

mmsqe added 3 commits April 13, 2023 10:47

rm AppendJournalEntry

d680d76

Merge branch 'main' into precompiled

4ea07ae

fix resolve

7f6a1c2

mmsqe force-pushed the precompiled branch from 59987ff to 7f6a1c2 Compare April 13, 2023 08:11

mmsqe added 3 commits April 13, 2023 22:05

revert cache store refactor

ac011e6

fix writeCache

d0451c7

check nil for writeCache and ms

aa147e6

mmsqe marked this pull request as ready for review April 13, 2023 14:46

mmsqe requested a review from a team as a code owner April 13, 2023 14:46

mmsqe requested review from facs95 and MalteHerrmann and removed request for a team April 13, 2023 14:46

github-actions bot removed the Status: Stale label Apr 14, 2023

add bank msg utility cmd

5377940

replace transfer with raw

github-advanced-security bot found potential problems Apr 17, 2023

View reviewed changes

github-actions bot added the Status: Stale label Jun 2, 2023

github-actions bot closed this Jun 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support stateful precompiled contracts #1650

feat: support stateful precompiled contracts #1650

mmsqe commented Feb 1, 2023 •

edited

Loading

github-actions bot commented Apr 8, 2023

yihuang Apr 13, 2023

mmsqe Apr 13, 2023

codecov bot commented Apr 13, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023

feat: support stateful precompiled contracts #1650

feat: support stateful precompiled contracts #1650

Conversation

mmsqe commented Feb 1, 2023 • edited Loading

Description

github-actions bot commented Apr 8, 2023

yihuang Apr 13, 2023

Choose a reason for hiding this comment

mmsqe Apr 13, 2023

Choose a reason for hiding this comment

codecov bot commented Apr 13, 2023 • edited Loading

Codecov Report

github-actions bot commented Jun 2, 2023

mmsqe commented Feb 1, 2023 •

edited

Loading

codecov bot commented Apr 13, 2023 •

edited

Loading