-
Notifications
You must be signed in to change notification settings - Fork 561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good but I'm afraid the contracts on geth were updated for the last time 2 years ago so there might be a few opcodes missing. Can you check that and add them too if possible?
Also, if you could add a README.md on the opcode/
directory to run the tests that would be amazing
Sure. Will do |
@yijiasu-crypto are you going to add the opcodes? or should we add them on a separate PR? |
Yes I think we could just merge this. I will issue a separate PR to add more opcode tests. |
@yijiasu-crypto can you create an issue to keep track of progress? |
* fix parse for websocket connID * update doc
Closes: #XXX
Description
Add some opcode test from the original
go-ethereum
protocol. Original test files can be found here: https://github.com/ethereum/go-ethereum/tree/master/tests/solidityThe opcode test will ask EVM to run all opcode defined by Ethereum Yellow Paper to make sure the EVM performs correctly.
Run
yarn test --network ethermint opcode
to perform this test.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)