This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
rpc: fix panic #611
Merged
rpc: fix panic #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
approved these changes
Oct 1, 2021
thomas-nguy
reviewed
Oct 1, 2021
ethereum/rpc/backend/backend.go
Outdated
| return nil, errors.Errorf("cannot fetch a negative block height: %d", height) | ||
| } | ||
| if height > int64(currentBlockNumber) { | ||
| // TODO: should we set height = int64(currentBlockNumber) ? |
There was a problem hiding this comment.
I have done a quick check and it seems that infura would return an empty response so current behavior is fine
fedekunze
added a commit
that referenced
this pull request
Oct 7, 2021
* docs: v0.6.0 changelog (#605) (#606) * docs: v0.6.0 changelog * update codeowners * build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.0 to 0.44.1 (#610) * build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.0 to 0.44.1 Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.44.0 to 0.44.1. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.44.1/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.44.0...v0.44.1) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * changelog Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze <[email protected]> * cmd: use config on genaccounts (#483) * cmd: use config on genaccounts * update * c++ * rpc: fix panic (#611) * rpc: fix panic * fix * c++ * rpc: restructure JSON-RPC directory and rename server config (#612) * Restructure ethermint/rpc repo structure and change import statements * Add #400 to changelog * fix filepath in util and json_rpc * Move #400 to unreleased section * evm: refactor `traceTx` (#613) * DNM: debug traceTx * c++ * deps: bump IBC-go (#621) * deps: bump IBC-go * changelog * evm, rpc: fix tx log attribute value is not parsable by some client (#615) * Problem: tx log attribute value not parsable by some client Closes: #614 Solution: - encode the value to json string rather than bytes Apply suggestions from code review * rm cdc and changelog Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze <[email protected]> * evm: fix iterator on deeply nested cache contexts (#617) * Problem: iterator on deeply nested cache contexts is extremely slow Closes: #616 Solution: - flatten cache contexts before doing `GetTxLogsTransient` * Update x/evm/keeper/context_stack.go * changelog Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze <[email protected]> * evm: add benchmark for deep context stack (#627) * Problem: deep context stack efficienty is not benchmarked Closes: #626 Solution: - add a benchmark to demonstrate an extremely inefficiency in deep context stack * Update x/evm/keeper/benchmark_test.go * prefix storage is irrelevant * add comment to state_transition.go Co-authored-by: Federico Kunze Küllmer <[email protected]> * rpc: support personal apis with different keyring backends (#591) * UPDATE Unlock keyring on start * ADD comment * ADD validation Co-authored-by: Federico Kunze Küllmer <[email protected]> * conflicts * changelog Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: davcrypto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.