Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

feat: add tx cli to build evm transaction #712

Merged
merged 1 commit into from
Nov 2, 2021
Merged

feat: add tx cli to build evm transaction #712

merged 1 commit into from
Nov 2, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 1, 2021

Closes #709

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze suggested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @yihuang. See comments below

x/evm/client/cli/tx.go Outdated Show resolved Hide resolved
x/evm/client/cli/tx.go Outdated Show resolved Hide resolved
x/evm/client/cli/tx.go Outdated Show resolved Hide resolved
x/evm/client/cli/tx.go Outdated Show resolved Hide resolved
x/evm/types/msg.go Show resolved Hide resolved
x/evm/types/msg.go Outdated Show resolved Hide resolved
x/evm/client/cli/tx.go Show resolved Hide resolved
x/evm/types/utils.go Outdated Show resolved Hide resolved
x/evm/client/cli/tx.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 1, 2021 •
edited
Loading

Codecov Report

Merging #712 (cc7284e) into main (d1446fc) will decrease coverage by 0.49%.
The diff coverage is 18.86%.

❗ Current head cc7284e differs from pull request most recent head 1d25832. Consider uploading reports for the commit 1d25832 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   57.01%   56.51%   -0.50%     
==========================================
  Files          63       64       +1     
  Lines        5532     5662     +130     
==========================================
+ Hits         3154     3200      +46     
- Misses       2197     2275      +78     
- Partials      181      187       +6
Impacted Files Coverage Δ
x/evm/client/cli/tx.go 0.00% <0.00%> (ø)
x/evm/module.go 54.68% <0.00%> (ø)
x/evm/types/msg.go 69.89% <57.14%> (-0.97%) ⬇️
encoding/config.go 88.09% <0.00%> (-11.91%) ⬇️
x/evm/types/access_list_tx.go 70.94% <0.00%> (+2.02%) ⬆️

@yihuang yihuang changed the title No tx cli to build evm transaction feat: add tx cli to build evm transaction Nov 1, 2021
fedekunze
fedekunze approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending Changelog entry and lint fixes

@yihuang
No tx cli to build evm transaction
1d25832 
Closes evmos#709

fix index

Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <[email protected]>

fix lint

transaction decoding unit test

test BuildTx

fix lint

changelog
@yihuang
Copy link
Contributor Author

yihuang commented Nov 2, 2021

ACK. Pending Changelog entry and lint fixes

done

@fedekunze fedekunze merged commit 10c49f7 into evmos:main Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No tx cli to build evm transaction
2 participants
@yihuang @fedekunze