Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: Missing debug_tranceBlockByHash RPC method and debug_traceBlock* may crash on non-existing block #743

Merged
merged 9 commits into from
Nov 12, 2021

Conversation

calvinaco
Copy link
Contributor

@calvinaco calvinaco commented Nov 11, 2021

Closes #742 and closes #744

Description

Add the missing method


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution: (Fix evmos#742) Add the missing method
@calvinaco calvinaco changed the title Problem: Missing debug_tranceBlockByHash RPC method Problem: Missing debug_tranceBlockByHash RPC method and debug_traceBlock* may crash on non-existing block Nov 11, 2021
init.sh Outdated Show resolved Hide resolved
rpc/ethereum/namespaces/debug/api.go Outdated Show resolved Hide resolved
rpc/ethereum/namespaces/debug/api.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) November 12, 2021 08:17
@fedekunze fedekunze merged commit 481e3b8 into evmos:main Nov 12, 2021
thomas-nguy referenced this pull request in crypto-org-chain/ethermint Nov 17, 2021
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants