Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: need to add JSON-RPC endpoint personal_listWallets #748

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Nov 15, 2021

Closes #745

  • wallet level that manages accounts is not supported by keyring interface, will return nil

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes evmos#745

* wallet level that manages accounts is not supported by keyring interface, will return nil
@fedekunze
Copy link
Contributor

linter is failing @Muggle-Du

@adu-web3
Copy link
Contributor Author

linter is failing @Muggle-Du

I see, but geth implement ListWallets in the same way.
Or should I make rawWallet public by replacing with RawWallet?

@adu-web3
Copy link
Contributor Author

lint failure fixed @fedekunze

@fedekunze fedekunze enabled auto-merge (squash) November 15, 2021 11:18
@fedekunze fedekunze added the C:JSON-RPC JSON-RPC client label Nov 15, 2021
@fedekunze fedekunze merged commit f42f339 into evmos:main Nov 15, 2021
@adu-web3 adu-web3 deleted the personal_listWallets branch November 15, 2021 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:JSON-RPC JSON-RPC client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: need to add JSON-RPC endpoint personal_listWallets
2 participants