Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

[Draft] add change base fee proposal #938

Closed

Conversation

thomas-nguy
Copy link
Contributor

@thomas-nguy thomas-nguy commented Feb 14, 2022

Closes: #937

Description

Allow to adjust the base fee value of the network in case it takes an absurd value

  • needs to write unit tests

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy force-pushed the thomas/basefee-change-proposal branch 2 times, most recently from 204162f to 226c6d9 Compare February 14, 2022 15:18
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #938 (1e2c3c8) into main (e16b7f8) will decrease coverage by 0.23%.
The diff coverage is 15.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   59.46%   59.23%   -0.24%     
==========================================
  Files          77       79       +2     
  Lines        6237     6268      +31     
==========================================
+ Hits         3709     3713       +4     
- Misses       2343     2370      +27     
  Partials      185      185              
Impacted Files Coverage Δ
x/feemarket/types/codec.go 0.00% <0.00%> (ø)
x/feemarket/types/proposal.go 14.28% <14.28%> (ø)
app/app.go 85.45% <100.00%> (+0.03%) ⬆️

@fedekunze
Copy link
Contributor

Hmm why don't you add the base fee as a module parameter? Then we won't need to maintain additional code

@thomas-nguy
Copy link
Contributor Author

yeah the idea is not to introduce breaking state change but if its okay to change the feemarket params, then it might be easier

@fedekunze
Copy link
Contributor

let's add it as a param instead

@thomas-nguy thomas-nguy changed the title add change base fee proposal [Draft] add change base fee proposal Feb 16, 2022
@thomas-nguy
Copy link
Contributor Author

#943

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a proposal type to be able to reinitialize feemarket base fee
2 participants