Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

json-rpc server should always use local rpc client #988

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Mar 14, 2022

Closes: #987
Solution:

  • use local rpc clint if json-rpc is enabled.

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: evmos#987
Solution:
- use local rpc clint if json-rpc is enabled.
@fedekunze
Copy link
Contributor

@yihuang can you fix the rpc tests?

@yihuang
Copy link
Contributor Author

yihuang commented Mar 15, 2022

@yihuang can you fix the rpc tests?

it seems not related to the PR, can you re-run it, maybe due to non-deterministicity?

@fedekunze fedekunze merged commit 49afc0f into evmos:main Mar 15, 2022
yihuang added a commit to yihuang/ethermint that referenced this pull request Mar 22, 2022
Closes: evmos#987
Solution:
- use local rpc clint if json-rpc is enabled.

Co-authored-by: Federico Kunze Küllmer <[email protected]>
yihuang added a commit to yihuang/ethermint that referenced this pull request Mar 24, 2022
Closes: evmos#987
Solution:
- use local rpc clint if json-rpc is enabled.

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json-rpc server should always use local rpc client
2 participants