Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @ember/string as a dependency #546

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Add @ember/string as a dependency #546

merged 1 commit into from
Jan 14, 2023

Conversation

boris-petrov
Copy link
Collaborator

To fix Ember 4.10 deprecation warnings

@boris-petrov boris-petrov force-pushed the add-ember-string branch 2 times, most recently from 121200f to cc8f490 Compare January 13, 2023 12:06
@boris-petrov
Add @ember/string as a dependency
01e3613 
To fix Ember 4.10 deprecation warnings
@boris-petrov boris-petrov changed the title Add @ember/string as a peer-dependency Add @ember/string as a dependency Jan 13, 2023
@ttill ttill merged commit bd78975 into master Jan 14, 2023
@ttill
Copy link
Contributor

ttill commented Jan 14, 2023

Thanks!

@boris-petrov boris-petrov deleted the add-ember-string branch January 16, 2023 09:36
@boris-petrov
Copy link
Collaborator Author

We'll have to move that to peerDependencies later (see discussion here). For now I believe it's fine like that. I'll release a new version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boris-petrov @ttill