refactor: check type as well

evolutionary-architecture · Jun 18, 2024 · ad25701 · ad25701
1 parent e0283e9
commit ad25701
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core/ValueObject.cs b/...-4-applying-tactical-domain-driven-design/Fitnet.Common/Fitnet.Common.Core/ValueObject.cs
@@ -4,7 +4,8 @@ public abstract class ValueObject : IEquatable<ValueObject>
 {
     protected abstract IEnumerable<object> GetEqualityComponents();
 
-    public bool Equals(ValueObject? other) => other is not null && IsSequenceEqual(other);
+    public bool Equals(ValueObject? other) =>
+        other is not null && GetType() == other.GetType() && IsSequenceEqual(other);
 
     public override bool Equals(object? obj)
     {