fix: get rid of call build service provider multiple times during feature flag resolving #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaboutsoftware
requested changes
Mar 28, 2024
… provider multiple times
kamilbaczek
force-pushed
the
feature/get_rid_of_call_build_service_provider_multiple_times
branch
from
d6891cb
to
f89ebac
Compare
meaboutsoftware
approved these changes
Mar 28, 2024
kamilbaczek
deleted the
feature/get_rid_of_call_build_service_provider_multiple_times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 PR Includes:
Fixed feature flag resolving mechanism during startup. The previous version used the build service provider on the main dependency injection container, resulting in dependencies being built multiple times, which caused issues in singleton services. (Reference: https://medium.com/@damien.vandekerckhove/why-you-shouldnt-call-buildserviceprovider-in-net-development-8e25f680d529)
The issue arises when the feature flag is resolved in the ServiceCollection part.
🛠️ Changes Made:
Implemented a new approach that creates a dedicated service provider, which is disposed of right away when the application's dependencies are registered. This new provider only contains dependencies that are used for feature flag resolution, thus isolating it from causing issues in other dependencies.