Add mixin for Hash conversions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the general N-ary case, we need to ensure we don't add more than two children to a node on a binary tree.
evolve75
added a commit
that referenced
this pull request
Oct 25, 2014
Add mixin for Hash conversions. Thanks to @jhamon.
|
Thanks! This is great, and thanks again for the clear and detailed documentation!. I have merged in your changes, and will upload 0.9.5pre very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that Issue #13 seems to have stalled for quite a long time. I had some time today to put this together and would like your feedback on it, @evolve75
Everything's organized into a new mixin,
Tree::Utils::HashConverter. This PR includes:Class methods
from_hash, builds aTree::TreeNodetree from a Ruby hashInstance methods
add_from_hash(somewhat similar toaddor<<, but for use when information for one or more child nodes is present in aHashobject).to_hhash export function.You'll see I also wrote a good number of assertions to verify functionality.