fix: fix strict comparison.

exadel-inc · Nov 23, 2020 · 5462ae3 · 5462ae3
1 parent f46b8cd
commit 5462ae3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/modules/esl-image/core/esl-image.ts b/src/modules/esl-image/core/esl-image.ts
@@ -279,7 +279,7 @@ export class ESLImage extends ESLBaseElement {
   }
 
   public updateContainerClasses() {
-    if (this.containerClass == null) return;
+    if (this.containerClass === null) return;
     const cls = this.containerClass || (this.constructor as typeof ESLImage).DEFAULT_CONTAINER_CLS;
     const state = isLoadState(this.containerClassState) && this[this.containerClassState];
     const targetEl = TraversingQuery.first(this.containerClassTarget, this) as HTMLElement;

diff --git a/src/modules/esl-media-query/core/esl-media-query.ts b/src/modules/esl-media-query/core/esl-media-query.ts
@@ -57,7 +57,7 @@ export class ESLMediaQuery {
     // Applying dpr shortcut
     this._dpr = 1;
     query = query.replace(/@([123])x/, (match, ratio) => {
-      this._dpr = Math.floor(ratio);
+      this._dpr = Math.floor(ratio); // FIXME
       if (ESLMediaQuery.ignoreBotsDpr && DeviceDetector.isBot && this._dpr !== 1) {
         return ESLMediaQuery.NOT_ALL;
       }
@@ -68,7 +68,7 @@ export class ESLMediaQuery {
     query = query.replace(/(and )?(@MOBILE|@DESKTOP)( and)?/i, (match, pre, type, post) => {
       this._mobileOnly = (type.toUpperCase() === '@MOBILE');
       if (DeviceDetector.isMobile !== this._mobileOnly) {
-        return ESLMediaQuery.NOT_ALL;
+        return ESLMediaQuery.NOT_ALL; // whole query became invalid
       }
       return pre && post ? ' and ' : '';
     });