Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛 in esl-base-component]: incorrect tag is used in case of postponed custom tag name definition #1804

Closed
ala-n opened this issue Jul 17, 2023 · 1 comment · Fixed by #1805
Closed

[🐛 in esl-base-component]: incorrect tag is used in case of postponed custom tag name definition #1804

ala-n opened this issue Jul 17, 2023 · 1 comment · Fixed by #1805
Assignees
@ala-n
Labels
bug Something isn't working hotfix released
Milestone
⚡ESL: 4.9.0 Minor...

Comments

@ala-n
Copy link
Collaborator

ala-n commented Jul 17, 2023

ESL components receive incorrect tag names in case of default tag override

Steps to Reproduce:

  1. Make sure you have components in markdown statically
  2. Initialize the component (with a delay)
await promisifyTimeout(1000);
// init...
  1. Use a custom tag name
ESLMedia.register('smart-media');
  1. Observe the components' initialization class

Current behavior
The class of initially existing components is set as the default

  <smart-media class="esl-media">

Expected behavior
The definition class should be used instead

  <smart-media class="smart-media">
@ala-n ala-n added bug Something isn't working hotfix labels Jul 17, 2023
@ala-n ala-n added this to the ⚡ESL: 4.9.0 Minor release milestone Jul 17, 2023
@ala-n ala-n self-assigned this Jul 17, 2023
ala-n added a commit that referenced this issue Jul 17, 2023
@ala-n
fix(esl-base-element): fix redefine tag feature (existing component r…
6c17690 
…eceives incorrect tag name)

Closes: #1804
@ala-n ala-n mentioned this issue Jul 17, 2023
Merged
ala-n pushed a commit that referenced this issue Jul 17, 2023
@semantic-release-bot
chore(release): 4.9.4
effb23d 
## [4.9.4](v4.9.3...v4.9.4) (2023-07-17)

### Bug Fixes

* **esl-base-element:** fix redefine tag feature (existing component receives incorrect tag name) ([6c17690](6c17690)), closes [#1804](#1804)
@ala-n
Copy link
Collaborator Author

ala-n commented Jul 17, 2023

🎉 This issue has been resolved in version 4.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Jul 17, 2023
@github-actions github-actions bot mentioned this issue Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ala-n ala-n

Labels
bug Something isn't working hotfix released
Projects
None yet
Milestone
⚡ESL: 4.9.0 Minor release
1 participant
@ala-n