fix(esl-utils): debounced unhandled rejection #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshovchko
requested review from
a team,
dshovchko,
ala-n,
julia-murashko,
abarmina,
NastaLeo,
Natalie-Smirnova and
HenadzV
and removed request for
a team
ala-n
requested changes
Jul 28, 2023
There was a problem hiding this comment.
Please consider an alternative approach:
- do not change debounce (most likely, at all). A similar issue may appear in other async decorators
- Make the
Deferredutility improved with a lazy<instanceof Deferred>.promiseinstead
The original request to make a class was related to Defered but not a denounced.
Please also provide tests to make sure we have no problem (ideally, first of all, make a unit test cases and make sure they are correct but not successful, and then provide a fix)
ala-n
reviewed
Jul 29, 2023
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
ala-n
added
the
require squash
julia-murashko
approved these changes
Aug 7, 2023
yadamskaya
approved these changes
Aug 7, 2023
HenadzV
approved these changes
Aug 8, 2023
NastaLeo
reviewed
Aug 8, 2023
NastaLeo
approved these changes
Aug 8, 2023
dshovchko
approved these changes
Aug 8, 2023
Co-authored-by: Anastasiya Lesun <[email protected]>
|
Code Climate has analyzed commit 4fb5a0a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.4% (0.1% change). View more on Code Climate. |
ala-n
force-pushed
the
main
branch
6 times, most recently
from
1f18a8a
to
6506db7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of this PR is to fix the issue described in #1801, and to refactor code from a function to a class
closes #1801