Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-toggleable): fix activator when close-on inner trigger click handled (#1852) #1853

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Aug 8, 2023

Fix activator when close-on inner trigger click handled + test coverage for related functionality

Closes: #1852

@ala-n ala-n requested review from a team, dshovchko, julia-murashko, yadamskaya and NastaLeo and removed request for a team August 8, 2023 20:49
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit 829c2b6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.5% (0.1% change).

View more on Code Climate.

@ala-n ala-n self-assigned this Aug 9, 2023
@ala-n ala-n added the needs review The PR is waiting for review label Aug 9, 2023
@ala-n ala-n added this to the ⚡ESL: 4.10.0 Minor release milestone Aug 9, 2023
@ala-n ala-n merged commit dde458e into main Aug 10, 2023
6 checks passed
@ala-n ala-n deleted the fix/incorrect-activator-on-close branch August 10, 2023 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
@ala-n ala-n added the released label Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 in esl-toggleable]: incorrect activator passed if out of the box close trigger has complex structure
4 participants