Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esl-event-listener): add condition descriptor property to legally prevent subscription #1958

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Sep 26, 2023

Closes: #1947

@ala-n ala-n added feature New feature under discussion needs review The PR is waiting for review labels Sep 26, 2023
@ala-n ala-n added this to the ⚡ESL: 4.13.0 Minor release milestone Sep 26, 2023
@ala-n ala-n requested review from a team September 26, 2023 01:53
@ala-n ala-n self-assigned this Sep 26, 2023
@ala-n ala-n requested review from dshovchko, julia-murashko and yadamskaya and removed request for a team September 26, 2023 01:53
src/modules/esl-event-listener/core/types.ts Outdated Show resolved Hide resolved
src/modules/esl-event-listener/core/api.ts Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Oct 10, 2023

Code Climate has analyzed commit c00152b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.0% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit 58947e5 into main Oct 10, 2023
6 checks passed
@ala-n ala-n deleted the feat/conditional-event-listeners branch October 10, 2023 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@ala-n
Copy link
Collaborator Author

ala-n commented Oct 25, 2023

🎉 This PR is included in version 4.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature needs review The PR is waiting for review released under discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 esl-event-listener]: (POC) condition property to legally prevent subscription
6 participants