fix: changes in the layout of the main page on github #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
abarmina
requested review from
ala-n,
andreybelous,
dshovchko,
nattallius,
PolinaVolchetskaya,
Sisha0,
YanaBr,
a team,
julia-murashko and
yadamskaya
and removed request for
a team,
julia-murashko and
yadamskaya
ala-n
reviewed
Jun 9, 2021
package.json
Outdated
| @@ -50,10 +50,10 @@ | |||
| "build-pages": "concurrently \"npm run build-pages:ts\" \"npm run build-pages:less\" && npm run build-pages:eleventy", | |||
| "build-pages:ts": "cd pages && webpack", | |||
| "build-pages:less": "lessc pages/src/localdev.less pages/static/bundles/localdev.css --source-map=pages/static/bundles/localdev.css.map", | |||
| "build-pages:eleventy": "eleventy", | |||
| "build-pages:eleventy": "ELEVENTY_ENV=production npx @11ty/eleventy", | |||
There was a problem hiding this comment.
Is it working in all OS?
It seems like I have a problem with running it in such a way on WIndows
Mb it has an option to pass environment as a regular command-line argument?
There was a problem hiding this comment.
you're right, it doesn't work on Windows. I rewrote this using a command-line argument
ala-n
approved these changes
Jun 9, 2021
dshovchko
approved these changes
Jun 10, 2021
YanaBr
approved these changes
Jun 10, 2021
andreybelous
approved these changes
Jun 10, 2021
abarmina
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing elements according to the current version of the page