Eli 47 transfer link inspector settings to granite console #62
Conversation
…-granite-console # Conflicts: # core/src/main/java/com/exadel/etoolbox/linkinspector/core/services/resolvers/ExternalLinkResolverImpl.java # core/src/main/java/com/exadel/etoolbox/linkinspector/core/services/resolvers/InternalLinkResolverImpl.java
…t' console. #47 -added missed fields to options page -fixed css styles
| @@ -68,4 +72,21 @@ public static void writeJsonResponse(SlingHttpServletResponse response, String j | |||
| LOG.error("Failed to write json to response", e); | |||
| } | |||
| } | |||
|
|
|||
| public static Resource createTab(ResourceResolver resolver, String path, String title, Collection<Resource> children) { | |||
There was a problem hiding this comment.
The methods are allright but I don't think they belong to ServletUtil. ServletUtil is exactly abound manipulating Request and Response. And these methods are about creating Synthetic resources. This is a different thing. They should be moved to another utility class.
I believe this is is going to be LinkInspectorResourceUtil.
Besides, the name of LinkInspectorResourceUtil should be cut down to ResourceUtil. The whole project is "Link Inspector" all around -- there is no need to repeat that in the name of a particular class.
Another option -- and maybe a better one -- is to create a new GraniteUtil class. That's because these are not just generic resource-creatign methods. They create a very special type of resources -- the ones for the Granite Datasource technology
| @@ -0,0 +1,114 @@ | |||
| package com.exadel.etoolbox.linkinspector.core.servlets; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
(cosmetic) Please observe this notice is put before the imports section here , but the same one is put after the imports section in the previous class. Need to put them in the same place,
Do we need these notices at all? No objection from my side, but:
- this is not customary for the project. Should all the other people start adding theirs in all the other classes?
- the authorship is clearly seen from GIT history anyway
|
|
||
| private Map<String, List<AttributeDefinition>> getServiceSettings() { | ||
| Map<String, List<AttributeDefinition>> result = new HashMap<>(); | ||
| for (LinkResolver linkResolver : linkResolvers) { |
There was a problem hiding this comment.
linkResolvers can be null so it is better to wrap in CollectionUtils.emptyIfNull()
…t' console. #47 -fixed git comments
- deleted 'Exclude tags' check box on options page
#52
#47 - implemented page with configs (load & save working automatically). available on /apps/etoolbox-link-
inspector/options/options.html. Needed implementation of internal integration with Link Inspector logic.
#37
#35